feat: administer explicit experience sharing grants - #9
Merged
Merged
Conversation
Add ExperienceFinalizationService: one call that loads a completed captured run, evaluates its own closed verification round, checks host authorization and the host's storage decision, reflects, creates the record as Candidate, and commits its initial lifecycle event to Validated or Quarantined. Record, reflection and event IDs derive from the run, so a retry re-derives them and converges instead of duplicating. Required checks can now name the evaluator kind that may satisfy them, and Core and Storage.Postgres each expose a service-registration extension. The MAF adapter finalizes a fully captured run through the host's resolver. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
Add IExperienceCandidateSource with a PostgreSQL implementation: scope, status and confidence filtering plus a full-text match over a generated tsvector column added by migration 0003. Core's ExperienceRetrievalService applies expiry and environment eligibility, then ranks candidates on relevance, confidence, recency, status and environment compatibility with configurable validated weights, exposing every normalized component and effective weight. Retrieval is bounded by a timeout that returns an empty result with a timeout signal rather than throwing, caller cancellation stays distinct, and a capped candidate pool is reported through Truncated. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
Add IExperienceEmbeddingIndex and a domain-typed embedding generator port, with a new AgentExperience.Storage.Postgres.Vectors package implementing them over plain Npgsql and Pgvector. Embeddings are derived data: indexing runs after the canonical commit, embeds only the sanitized retrieval summary of an eligible record, and writes conditionally on the record's exact revision, so a stale write is rejected and a deleted record is never recreated. Retrieval gains a vector channel merged with the text channel under the same eligibility, timeout and ceiling. A model or dimension mismatch, an unavailable provider, or a vector-channel failure produces an explicit flagged text-only result rather than an incompatible comparison. The vectors package owns and applies its own schema, so a text-only deployment never runs CREATE EXTENSION vector. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
Add ExperienceContextProvider, a simple-tier AIContextProvider the host adds to ChatClientAgentOptions.AIContextProviders. It retrieves ranked experience before an invocation, re-checks every candidate against the same eligibility rules retrieval applies, asks the host's injection decision, and injects a delimited Historical Reference carrying source, confidence, applicability and an evidence summary -- never raw payload content, never a cut record. Limits drop whole records and record every omission. Retrieval that is empty, times out or fails leaves the agent running normally. Labeling marks the content untrusted; the authorization boundary is what denies an unauthorized tool call, and a test proves it does when the model obeys injected text. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
Add IExperienceGrantStore and migration 0005: an administrator, with authority the host supplies explicitly, grants one record to a recipient scope with a reason and an expiry. The grant row and its audit event commit together, and a unique partial index allows at most one active grant per recipient, so revoking the grant an administrator knows about ends that recipient's access. Reads widen in SQL only: get, text search and vector search match their exact scope or an active grant, evaluated against the database clock. Writes, lifecycle commits, history and enumeration stay owner-only. The read that applied the predicate marks a record as shared, so Core and the injection provider keep strict scope equality for everything else, the host's risk policy can deny borrowed experience, and the model is told the lesson came from another scope. Deployments without the grants table, or with SELECT only on the record table, degrade to exact-scope reads rather than failing. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Story 3.1, first of Epic 3. Scope stops being all-or-nothing, without weakening it.
GrantAdministrationthe host constructs — never derived from anAuthorizationContext, a role string, or the requesting scope. Missing it is a typedDeniedbefore any connection opens.INSERT ... SELECT, so a caller cannot assert who owns what.GetHistoryAsyncexposes the trail through the port.clock_timestamp()so a caller-held transaction cannot keep an expired grant alive. Writes, lifecycle commits, history and enumeration stay owner-only.0005, or a role with SELECT only on the records table, falls back to exact-scope reads and notifies the host — degrading only ever narrows a read.Review
Three reviewers raised 31 findings; 28 fixed, 3 deferred with named owners. Blind Hunter could not construct a case where the predicate admits a record the grant does not name. The serious ones: grants initially broke un-migrated and least-privilege deployments; relaxing the Core and MAF scope guards had weakened defence in depth (fixed by the marker above); an audit event could silently not be written; and revoking one of several overlapping grants did not end access.
Not in this PR
Tamper-evident grant state (a direct
UPDATEcan still clear a revocation) is assigned to 3.2, which owns the same question for lifecycle events. Grant purge, a lifetime ceiling and read auditing are assigned to 4.5 and to a new story 3.5.Test plan
dotnet build --configuration Release: 0 warnings, 0 errorsdotnet test --configuration Release: 746 of 746 pass (Postgres 165, Core 394, MAF 90, Vectors 45)🤖 Generated with Claude Code